fix(TMCU-1048): Remove redundant useElevatedSurface from MMDS BottomSheet callsites#33159
Conversation
…heet callsites MMDS BottomSheet now handles pure-black elevated surface internally. Remove the useElevatedSurface shim and twClassName prop from: - ConfirmTurnOnBackupAndSyncModal - LearnMoreBottomSheet Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
PR template — items to address before "Ready for review"Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
These are near-cosmetic changes (removing a theme utility class from a UI wrapper). No controller logic, navigation, data flow, or functional behavior is changed. The risk is very low.
No performance tests are warranted as these are purely styling/cosmetic changes with no impact on rendering performance, data fetching, or app launch times. Performance Test Selection: |
|
|
|
||
| return ( | ||
| <BottomSheet ref={bottomSheetRef} twClassName={surfaceClass}> | ||
| <BottomSheet ref={bottomSheetRef}> |
There was a problem hiding this comment.
MMDS BottomSheetDialog applies elevated surface styling internally since design-system-react-native 0.33 (background.alternative via usePureBlack when MM_PURE_BLACK_PREVIEW is on). useElevatedSurface returned bg-alternative in that same mode, so removing twClassName does not change the sheet surface. LearnMoreBottomSheet is the same pattern.



Description
MMDS
BottomSheetnow handles pure-black elevated surface styling internally. This PR removes the redundantuseElevatedSurface()shim andtwClassNameprop from the two remaining accounts-engineer callsites scoped in TMCU-1048.Changes:
ConfirmTurnOnBackupAndSyncModal— removeduseElevatedSurfaceimport/usage andtwClassNameonBottomSheetLearnMoreBottomSheet— removeduseElevatedSurfaceimport/usage andtwClassNameonBottomSheetChangelog
CHANGELOG entry: null
Related issues
Fixes: TMCU-1048
Manual testing steps
N/A for automated cloud-agent environment — visual QA requires device/simulator with pure black preview enabled.
Screenshots/Recordings
N/A — visual surface change only; requires device QA with pure black preview enabled per acceptance criteria.
Before
N/A
After
Backup and Sync BottomSheet background color still works as expected
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an examplePre-merge reviewer checklist